[10:57:52]  MarkUsBot joined #markus.
 [10:58:18] <m_conley>  we gotta stop rebooting the markusproject machine..
 [10:59:15] <NelleV>  who is rebooting the machine ?
 [11:02:48] <m_conley>  Dunno
 [11:03:08] <m_conley>  I have a feeling that we're running out of memory / thrashing, and so the machine gets restarted
 [11:03:17] <m_conley>  we should probably shut down the un-used RB instance.
 [11:04:09] <NelleV>  how come markusbot doesn't restart properly ?
 [11:04:42] <m_conley>  NelleV: the .pid file doesn't get wiped out when we restart the machine, so the script just assumes it's still running
 [11:04:48] <m_conley>  not the smartest script in the world
 [11:05:09] <NelleV>  m_conley: the script should probably check the pid indeed exists
 [11:05:15] <NelleV>  m_conley: isn't a python script ?
 [11:05:22] <m_conley>  NelleV: I believe so, yeah
 [11:05:42] <NelleV>  then it should be quite straight forward to fix that
 [11:08:33] <NelleV>  m_conley: we should add a try: os.kill(pid, 0); except OSError: #the pid doesn't exists
 [11:09:53] <m_conley>  NelleV: yeah - something like that'd work
 [11:10:10] <m_conley>  NelleV: kinda super-busy right now, but maybe I'll do it next time this crops up. :)
 [11:53:40]  mikeing2001 (80646d4a@gateway/web/freenode/ip.128.100.109.74) joined #markus.
 [11:53:57]  mikeing2001 (80646d4a@gateway/web/freenode/ip.128.100.109.74) left irc: Client Quit
 [11:54:10]  mikeing20011 (~g9mike@128.100.109.74) joined #markus.
 [12:00:03]  karenreid (~reid@red-gw77.cs.toronto.edu) joined #markus.
 [12:00:04] <karenreid>  9
 [12:00:19] <mikeing20011>  you do like the number 9
 [12:00:25]  jolle (~jeeulo@d172-219-72-83.abhsia.telus.net) joined #markus.
 [12:00:30] <mikeing20011>  and 9 to you
 [12:00:33] <mikeing20011>  :P
 [12:00:37] <karenreid>  sigh
 [12:01:02] <karenreid>  Hi everyone.
 [12:01:09] <jolle>  ahoy :)
 [12:01:34] <karenreid>  I'm frustrated because I had planned to work on MarkUs stuff for much of the morning and have been thwarted by multiple interruptions. :-(
 [12:02:54] <karenreid>  I also have to figure out how to get the linode server to behave better. :-(
 [12:03:27] <karenreid>  Let's wait a couple of minutes to see if we get a few more people. I know that Kira won't be here
 [12:04:11] <mikeing20011>  Andrey said he can't make it either
 [12:04:54] <karenreid>  if m_conley or NelleV have a minute, could you help me figure out how to reset my ssh key on the linode server so I can log in? (I also can't find the password for root on the server.)
 [12:11:33] <karenreid>  Hmm. jolle and mikeing20011, why don't you give your status reports. (I'm surprised that the turn out is so low today.)
 [12:13:01] <jolle>  what am empty meeting!
 [12:13:16] <jolle>  I've been digging into bug 904, the old scores not showing
 [12:13:28] <mikeing20011>  ahh
 [12:13:34] <jolle>  I'm getting familiar with all of the surrounding code, from the view to the controller to the model
 [12:14:27] <jolle>  I'm getting a better sense of things
 [12:14:43] <jolle>  and I have a consistent fix!
 [12:15:05] <jolle>  if you select a mark for the bottom criterion then refresh the page all of the old marks show up
 [12:15:13] <mikeing20011>  karenreid: do you know what the demo server is running in terms of ruby?
 [12:15:32]  e-morency (cea7b6cd@gateway/web/freenode/ip.206.167.182.205) joined #markus.
 [12:15:49] <jolle>  that's where I'm at, still digging for the bug now. I also sent ante an email with all the remark request details and he should be fishing into this stuff with me
 [12:16:17] <e-morency>  hi, sorry I'm a bit late
 [12:17:07] <jolle>  hello!
 [12:20:19] <e-morency>  did I timeout?
 [12:20:26] <mikeing20011>  no
 [12:20:40] <e-morency>  ok
 [12:21:54] <karenreid>  hi, sorry for the non-response
 [12:22:12] <karenreid>  mikeing20011: I suspect it is running 1.8.x
 [12:23:34] <mikeing20011>  really
 [12:24:18] <mikeing20011>  because last night i was looking at jolle issue and it's not reproducible on the demo server but it was reproducible on my local setup
 [12:24:33] <mikeing20011>  and I was seeing what is the difference
 [12:24:35] <karenreid>  mikeing20011: to be honest I'm not sure
 [12:25:09]  joeyperry (~joeyperry@wpa-2-1636.cc.umanitoba.ca) joined #markus.
 [12:25:24] <joeyperry>  sorry I'm late! was giving a presentation
 [12:25:35] <joeyperry>  (so obviously I couldn't be lurking the chat)
 [12:26:47] <jolle>  I saw a lot save(false) statements, which should be save(:validate => false)
 [12:27:33] <jolle>  maybe I should look for other deprecated rails things
 [12:28:36] <joeyperry>  I wonder if there's a gem or script of some kind, that can search out your project and find all the deprecations
 [12:28:51]  *** karenreid sigh. one of those days...
 [12:29:49] <mikeing20011>  joeyperry: everything that is deprecated we should have an imported files so that there are support
 [12:30:21] <mikeing20011>  so if you can find that file then you will know what functions are deprecated
 [12:30:49] <karenreid>  mikeing20011: is this about ruby1.9 issues?
 [12:31:06] <mikeing20011>  this will be about rails 3.0
 [12:32:09] <karenreid>  thanks
 [12:33:56] <karenreid>  I'm having trouble figuring out what question to ask...
 [12:34:30] <karenreid>  jolle: you can reproduce the bug with the marks not showing up but that isn't reproducible on the server?
 [12:35:10] <jolle>  I can reproduce it with the master version of the code
 [12:35:29] <jolle>  I haven't tried the server, but mike was saying that the bug is not present there
 [12:35:46] <joeyperry>  what's this bug?
 [12:35:52] <mikeing20011>  i could reproduce on my local machine as well
 [12:36:15] <mikeing20011>  it is really odd, that's why I am wondering if there is a software difference
 [12:36:33] <jolle>  https://github.com/MarkUsProject/Markus/issues/904
 [12:36:36] <karenreid>  there could be. We should add the rails and ruby version info to the "about" page.
 [12:38:04] <karenreid>  We also saw the case where simply viewing the remark request (as the instructor) and then navigating away would cause the old marks to disappear.
 [12:38:12] <karenreid>  Is that the same issue?
 [12:38:32] <jolle>  I haven't noticed that
 [12:38:52] <jolle>  I'll try to reproduce it, but it sounds very similar
 [12:39:07] <karenreid>  That could be a version thing if the data was there all along.
 [12:39:21] <jolle>  yeah, it does seem like the data is never lost
 [12:39:42] <karenreid>  which is a relief, but makes it a bit more puzzling to fix the display issues.
 [12:40:12] <jolle>  I did some logging
 [12:40:31] <jolle>  when the controller is first run the "edit" method is called, and the oldmark value in there is always nil
 [12:40:55] <jolle>  but when you click a mark it calls "update_mark" and the old mark has the correct value there
 [12:41:04] <karenreid>  I'm hoping one of the other admins will figure out how to get me login permission on the server again so I can look into some of these things.
 [12:42:25] <karenreid>  is the deprecated code a worry? or just one of those mundane tasks that needs to be done.
 [12:42:44] <jolle>  I think its just a warning, it doesn't seem to break anything
 [12:42:53] <jolle>  but then again we have an unsolved bug, so I don't know :P
 [12:43:42] <karenreid>  I don't usually like to change too many things at one time, but it is probably worth fixing the deprecated code
 [12:43:51] <karenreid>  at least the easy part, as you go...
 [12:44:24] <karenreid>  e-morency: did you want to give your status update? (I did read all the emails)
 [12:44:54] <m_conley>  karenreid: could you email me your public SSH key?
 [12:45:16] <karenreid>  m_conley: will do
 [12:45:18] <e-morency>  well I will probably repeat myself, but I can give one
 [12:45:25] <e-morency>  As you probably already know I had a problem with the show8hide column popup not showing as a TA (and I didn't know where it came from), but I finally fixed it by adding rights for it to the TAs (I didn't know there were explicit rights)
 [12:46:10] <e-morency>  I also started work on the text for the blog post about user preferences
 [12:46:29] <e-morency>  and that's about it,
 [12:47:02] <e-morency>  I started refactoring the submissions user preferences a bit before creating a pull request since the code wasn't very clean
 [12:47:20] <e-morency>  I'll then create a pull request and finish writing the blog post
 [12:48:03] <karenreid>  sounds good
 [12:48:19] <karenreid>  joeyperry: I hope your presentation went well. Anything to report?
 [12:50:45] <joeyperry>  presentation went a-okay
 [12:51:10] <joeyperry>  I just pulled the most recent changes, and now it seems like my ajax calls on the assign graders page are logging me out...
 [12:51:21] <karenreid>  :(
 [12:51:25] <joeyperry>  it may be just on my server though, so I'll have to investigate
 [12:51:34] <e-morency>  I encountered the issue as well
 [12:51:38] <e-morency>  but it looked a bit random
 [12:51:45] <e-morency>  sometimes it logged me out, sometimes it didn't
 [12:51:50] <mikeing20011>  joeyperry: I have experence that before
 [12:52:00] <joeyperry>  yeah, I know what the cause is, well, the random cause
 [12:52:22] <mikeing20011>  to me it seems it will only log you out if it has not finish loading the all the information
 [12:52:33] <mikeing20011>  actually i think only graders
 [12:52:35] <karenreid>  (I was just imagining the complaints from students about this one. :P )
 [12:52:49] <joeyperry>  the ajax javascript sends the AUTH_TOKEN to the server, with it's request to avoid cross scripting exploits
 [12:52:53]  antez (8e670d78@gateway/web/freenode/ip.142.103.13.120) joined #markus.
 [12:52:59] <joeyperry>  some of the calls escape this properly, some don't
 [12:53:06] <mikeing20011>  but this was/has been a old issue before on other pages i think
 [12:53:19] <joeyperry>  it's just a randomly generated string, so sometimes it can have characters that need to be escaped
 [12:53:48] <joeyperry>  if you create a string of parameters to send, it will need to be manually escaped
 [12:53:57] <joeyperry>  but if you send a hash of parameters, it will be escaped automatically
 [12:54:27] <joeyperry>  send the wrong one, and it wiill null your cookie and try to forward you to the login screen, but ends up just looking like things stop working
 [12:54:39] <joeyperry>  in fixing up the javascript, I've been fixing any case of this
 [12:54:51] <joeyperry>  what I'm experiencing now though, is it's sending the AUTH_TOKEN, but no other parameters
 [12:55:02] <joeyperry>  so it's probably just something I was in the middle of and forgot about...
 [12:55:40] <joeyperry>  aaanyway, the last thing I worked on was trying to fix the 'flexible_criteria" marking for assignments, which I fixed, and then found out that mike had already fixed and submitted a pull request for the same issue
 [12:56:06] <joeyperry>  so I'm going to call it a learning experience, and try to get any extra tweaks I did on top of mikes fixes merged in once his is pulled
 [12:56:09] <mikeing20011>  https://github.com/MarkUsProject/Markus/issues/722
 [12:56:14] <karenreid>  did the issue get closed?
 [12:56:24] <mikeing20011>  similar issue\
 [12:56:26] <joeyperry>  it's not up yet
 [12:56:32] <joeyperry>  yeah, exactly the same :P
 [12:56:38] <karenreid>  sigh
 [12:56:45] <joeyperry>  when I started working on it, I thought it would be a quick fix
 [12:56:53] <joeyperry>  but it ended up being more involved, and I was on a roll... It's my own fault for not checking
 [12:57:03] <joeyperry>  I know have known, since it was a full feature that was broken
 [12:57:31] <joeyperry>  but once that is fixed, then I can finish off removing all the prototype_legacy_helper stuff, since that page uses some of it
 [12:59:00] <joeyperry>  in the meantime though, I'll try to find some older "easy" tagged bugs and fix a few of those
 [12:59:15] <karenreid>  sounds good
 [13:00:15] <mikeing20011>  joeyperry: just a reminder, all prototype legacy stuff should be removed before we release markus 1.0
 [13:00:29] <joeyperry>  workin' on it :)
 [13:00:33] <mikeing20011>  so if you need any help because there is too much speak up
 [13:00:38] <joeyperry>  my goal is to remove the gem entirely
 [13:01:01] <joeyperry>  there's not much left, from what I can see
 [13:01:10] <mikeing20011>  that is what i think to
 [13:01:10] <joeyperry>  but I'll let you know if anything goes horribly wrong
 [13:01:17] <mikeing20011>  ok
 [13:01:23] <mikeing20011>  i got to go to class now
 [13:01:46] <mikeing20011>  here is my status
 [13:01:46] <mikeing20011>  so what i am working on is starting to update the documentations with the latest information. Need to do some testing with ruby 1.9 to make sure everything works as expected.
 [13:02:20] <karenreid>  thanks mikeing20011
 [13:02:32] <mikeing20011>  ok bye\
 [13:02:35]  mikeing20011 (~g9mike@128.100.109.74) left #markus.
 [13:02:40] <karenreid>  are people using ruby 1.9 or is anyone still using 1.8.x
 [13:02:41] <karenreid>  ?
 [13:03:15] <karenreid>  mike is trying to figure out whether we can release with 1.9 and it would be ideal if everyone was developing using 1.9, unless there are some reasons not to.
 [13:03:18] <antez>  Hi. Which one should we use? I forgot which I am using.
 [13:03:34] <e-morency>  I'm still using 1.8.x
 [13:03:48] <antez>  ok. I will switch if iam not already using 1.9
 [13:04:22] <karenreid>  If you come up against serious road blocks with the switch please send email to the dev list.
 [13:04:38] <karenreid>  The other reason to make the switch is that the testing group needs 1.9 for the libraries they are using.
 [13:05:01] <antez>  question, should this issue be closed and if yes how? https://github.com/MarkUsProject/Markus/issues/315
 [13:05:50] <joeyperry>  karenreid, I'm using 1.9.3
 [13:06:02] <karenreid>  joeyperry: great
 [13:06:24] <karenreid>  antez: thanks for the not. I closed it
 [13:06:30] <karenreid>  *note
 [13:06:48] <jolle>  ok, I'm out for today, have a good friday everyone
 [13:06:48] <antez>  Thanks. Now there is no issue assigned to me.
 [13:07:31] <e-morency>  Thanks, I'll be leaving as well, have a good weekend
 [13:07:50]  jolle (~jeeulo@d172-219-72-83.abhsia.telus.net) left irc: Quit: Leaving
 [13:07:52] <antez>  guess I should report my status although the meeting is over.
 [13:08:00]  e-morency (cea7b6cd@gateway/web/freenode/ip.206.167.182.205) left irc: Quit: Page closed
 [13:09:03] <karenreid>  antez: I'm still here. :-)
 [13:09:53] <antez>  I sent a pull request for adding disable_with tags for all f.submit buttons. But I did not test every single one of them so maybe I should do that before the pull request gets accepted
 [13:10:20] <karenreid>  It would be good to make sure that they still all work.
 [13:10:55] <antez>  Agree. So I will test them tomorrow
 [13:11:00] <joeyperry>  the pull request already went through
 [13:11:04] <joeyperry>  I've got the changes
 [13:11:34] <antez>  Did it break anything yet?
 [13:11:39] <joeyperry>  not that I can tell
 [13:11:50] <karenreid>  :-) That's a good sign.
 [13:11:56] <joeyperry>  I tested on a few pages that did ajax calls, because the buttons should be re-enabled after the call
 [13:12:07] <joeyperry>  but I'm not sure if those buttons were included
 [13:12:07] <antez>  Oh,well, I will still test it.
 [13:12:22] <joeyperry>  I should also make sure that I have an appropriate "disabled" style, since I changed over the buttons
 [13:13:18] <antez>  I only change buttons that can be searched in the source with "f.submit "
 [13:16:21] <antez>  So my next step will be remark request.
 [13:18:27] <joeyperry>  okay, just tested one of the submit buttons, works fine
 [13:18:32] <karenreid>  sounds good
 [13:18:34] <joeyperry>  with an ajax call
 [13:18:48] <joeyperry>  it disables and goes to "working..." and then reactivates once the call is completed
 [13:18:55] <antez>  Thanks testing it.
 [13:19:04] <joeyperry>  also, I found the issue that was causing me to be logged out of the groups page
 [13:19:12] <joeyperry>  redundant js includes, again :P
 [13:19:17] <karenreid>  :-)
 [13:19:29] <karenreid>  at least you know what to look for
 [13:20:05] <joeyperry>  yeah, sometimes it's tricky though
 [13:22:47] <joeyperry>  I guess if I make it the first thing I check though, eventually all of it will be cleaned up
 [13:24:33] <antez>  how to log in as student on the markus demo?