[00:00:40] <baadshah>  so for issue 602..when i upload a new diff after suggested changes..should i upload the diff which is between the master and the branch i'm working on?
 [00:00:44] <baadshah>  even though most of it might be reviewed
 [00:03:40] <baadshah>  ddadacha: nvm
 [00:20:36]  baadshah (~jay@CPE001346fab9ed-CM602ad086fb19.cpe.net.cable.rogers.com) left irc: Quit: leaving
 [00:23:04]  tobioboye (~drone@gw-wifi11.cdf.toronto.edu) joined #markus.
 [00:50:49]  ddadacha (~ddadacha@user250-10.wireless.utoronto.ca) left irc: Ping timeout: 240 seconds
 [00:52:22]  ddadacha (~ddadacha@user250-10.wireless.utoronto.ca) joined #markus.
 [01:47:27]  ddadacha (~ddadacha@user250-10.wireless.utoronto.ca) left irc: Ping timeout: 248 seconds
 [01:47:43]  ddadacha (~ddadacha@user250-10.wireless.utoronto.ca) joined #markus.
 [01:59:45]  baadshah (~jay@CPE001346fab9ed-CM602ad086fb19.cpe.net.cable.rogers.com) joined #markus.
 [02:01:03] <baadshah>  hey guys..i was wondering if you can review my request for issue 483. It's a very small change severin asked me to change. So just waiting on a review from a core-dev to ship it! :)
 [02:12:43] <ddadacha>  baadshah: doing it now
 [02:15:30] <baadshah>  ddadacha: awesome thank you! :) and i've other ones up too..but this one has been just waiting for over a week..so want to get it done :)
 [02:15:53] <ddadacha>  baadshah: you may have to wait a bit longer :P
 [02:15:59] <ddadacha>  baadshah: read my comments
 [02:16:03] <ddadacha>  all small stuff
 [02:17:01] <ddadacha>  baadshah: before doing the pull request, make sure you have the fr translation
 [02:17:13] <ddadacha>  easiest way to do that is to ask for translations by email
 [02:19:28] <baadshah>  ddadacha: okay no problem...thank you! :) will send out an email to markus-dev
 [02:20:06] <ddadacha>  baadshah: awesome..alternatively you can ping spam the French devs and point them to the review
 [02:24:36] <baadshah>  ddadacha: oh..ya i already sent the email
 [02:51:45]  ddadacha (~ddadacha@user250-10.wireless.utoronto.ca) left irc: Ping timeout: 265 seconds
 [02:55:51]  tobioboye (~drone@gw-wifi11.cdf.toronto.edu) left irc: Quit: tobioboye
 [02:58:25]  baadshah (~jay@CPE001346fab9ed-CM602ad086fb19.cpe.net.cable.rogers.com) left irc: Quit: leaving
 [03:22:10]  MarkUsGithubCIA (~MarkUsGit@sh2.rs.github.com) joined #markus.
 [03:22:10] <MarkUsGithubCIA>  [Markus] NelleV pushed 5 new commits to master: http://git.io/C-CLDQ
 [03:22:10] <MarkUsGithubCIA>  [Markus/master] Merge branch 'master' of git://github.com/MarkUsProject/Markus - Jay Parekh
 [03:22:10] <MarkUsGithubCIA>  [Markus/master] fixed some indentation - Jay Parekh
 [03:22:10] <MarkUsGithubCIA>  [Markus/master] Merge branch 'master' into issue483_annotation - Jay Parekh
 [03:22:10]  MarkUsGithubCIA (~MarkUsGit@sh2.rs.github.com) left #markus.
 [03:25:38]  baadshah (~jay@CPE001346fab9ed-CM602ad086fb19.cpe.net.cable.rogers.com) joined #markus.
 [03:27:42] <baadshah>  NelleV: hey Nelle..in the last pull request that i sent..i accidentally had another file from my local copy which got accidentally added..is it possible for u to remove it?
 [03:29:41] <NelleV>  baadshah: which one ?
 [03:30:54] <baadshah>  NelleV: file is called..."issue681_failedTests.txt"
 [03:31:18] <NelleV>  baadshah: it's not there. You've deleted it in a commit already
 [03:31:26] <baadshah>  NelleV: yaa i'm sorry but when i updated my master i realized it got added there
 [03:31:31] <baadshah>  ohh
 [03:31:56] <baadshah>  NelleV: did you update your upstream just now?
 [03:32:52] <baadshah>  NelleV: i mean your local master..sry i'm sleepy lol
 [03:33:24] <NelleV>  baadshah: I was the one who did the last merge, and there hasn't been any commits to the repo since
 [03:33:47] <baadshah>  NelleV: ohh okay then.. as long as it didn't get added to the upstream master
 [03:34:00] <baadshah>  I thought for sure when i pulled that file..that's where i had it
 [03:34:25]  tobioboye (~drone@65.95.182.241) joined #markus.
 [03:34:25] <NelleV>  baadshah: you added it then deleted it, so when I did the merge, it was added then deleted
 [03:34:36] <baadshah>  NelleV: ahh i see it just now :)
 [03:34:45] <baadshah>  NelleV: okay awesome..thanks :)
 [03:35:21] <baadshah>  NelleV: one more thing..it's my first time updating the wiki..if you have some time can you check my pull request for the wiki change?
 [03:36:12] <NelleV>  eh
 [03:36:20] <NelleV>  you haven't done any PR to the markus wiki
 [03:37:21] <NelleV>  you've done one to markus's codebase, which seems to be a PR in a git submodule, but we don't have anuy git submodule
 [03:37:56] <baadshah>  NelleV: is the title for that..Mysql wiki?
 [03:38:28] <NelleV>  yes
 [03:38:38] <baadshah>  it said to clone Markus.wiki, make changes to the file..and commit like other files..so i did the same..
 [03:40:46] <NelleV>  where did you find that information ? It is indeed what we have to do, but I think you created a git submodule or cloned the git repo in another git repo
 [03:41:06] <baadshah>  mm
 [03:42:01] <baadshah>  NelleV: oh i think i know..i copied the link from my cloned markus
 [03:59:38]  tobioboye (~drone@65.95.182.241) left irc: Quit: tobioboye
 [04:23:56]  baadshah (~jay@CPE001346fab9ed-CM602ad086fb19.cpe.net.cable.rogers.com) left irc: Quit: leaving
 [10:12:31]  MarkUsGithubCIA (~MarkUsGit@sh2.rs.github.com) joined #markus.
 [10:12:31] <MarkUsGithubCIA>  [Markus] jerboaa pushed 2 new commits to master: http://git.io/Z0qn-Q
 [10:12:31] <MarkUsGithubCIA>  [Markus/master] Update populate to match new interface for upload_user_list - Nelle Varoquaux
 [10:12:31] <MarkUsGithubCIA>  [Markus/master] Merge pull request #699 from NelleV/FIX_populate - Severin Gehwolf
 [10:12:31]  MarkUsGithubCIA (~MarkUsGit@sh2.rs.github.com) left #markus.
 [11:15:34]  tobioboye (~drone@65.95.182.241) joined #markus.
 [11:26:05]  MarkUsGithubCIA (~MarkUsGit@sh1-ext.rs.github.com) joined #markus.
 [11:26:05] <MarkUsGithubCIA>  [Markus] jerboaa pushed 1 new commit to master: http://git.io/eShPaw
 [11:26:05] <MarkUsGithubCIA>  [Markus/master] Closes #620. - Jay Parekh
 [11:26:05]  MarkUsGithubCIA (~MarkUsGit@sh1-ext.rs.github.com) left #markus.
 [11:28:23]  ddadacha (~ddadacha@173-230-167-62.cable.teksavvy.com) joined #markus.
 [12:55:19]  aimenk (~aimenk@199.243.188.82) joined #markus.
 [12:57:16] <tobioboye>  hey NelleV just wondering did the assignment summary graphs ever work :)
 [12:58:01] <tobioboye>  NelleV: nvm
 [13:24:07]  tobioboye (~drone@65.95.182.241) left irc: Quit: tobioboye
 [13:28:18]  ddadacha (~ddadacha@173-230-167-62.cable.teksavvy.com) left irc: Ping timeout: 272 seconds
 [15:57:42]  aimenk (~aimenk@199.243.188.82) left irc: Ping timeout: 244 seconds
 [16:03:58]  aimenk (~aimenk@199.243.188.82) joined #markus.
 [16:20:18]  baadshah (~jay@user253-216.wireless.utoronto.ca) joined #markus.
 [16:38:18]  hanson (6031eecc@gateway/web/freenode/ip.96.49.238.204) joined #markus.
 [16:57:24]  hanson (6031eecc@gateway/web/freenode/ip.96.49.238.204) left irc: Quit: Page closed
 [17:13:19]  baadshah (~jay@user253-216.wireless.utoronto.ca) left irc: Read error: Operation timed out
 [17:21:24]  tobioboye (~drone@69.156.29.233) joined #markus.
 [17:21:31]  hanson (6031eecc@gateway/web/freenode/ip.96.49.238.204) joined #markus.
 [17:22:08] <hanson>  hey guys, does anyone know how to add an extra percentage bonus, in the results page? I see add Extra Mark, but nothing for add Extra Percentage
 [17:24:14] <tobioboye>  hey hanson I don't think it is possible for you to add extra percentage from the results page
 [17:24:52] <hanson>  tobioboye: thanks, do you know where I could? :(
 [17:25:17] <tobioboye>  I don't think you can do at all
 [17:26:23]  ddadacha (~ddadacha@173-230-167-62.cable.teksavvy.com) joined #markus.
 [17:31:54] <hanson>  hey danesh ddadacha
 [17:32:09] <ddadacha>  hanson: hey
 [17:32:17] <ddadacha>  hanson: just replied to your test failure email
 [17:32:25] <hanson>  I saw that, posted on the issue page :)
 [17:32:35] <hanson>  question about the link_to_remote stuff you did in results...
 [17:32:41] <hanson>  I tried it and it doesnt work for me :S
 [17:33:10] <ddadacha>  hmm which one?
 [17:33:44] <hanson>  remove_extra_mark
 [17:34:15] <hanson>  actually hmm..weird
 [17:34:17] <ddadacha>  hanson: oh the ones I did by mistake and emailed you about?
 [17:34:29] <hanson>  I changed routes.rb to use GET for that method
 [17:34:46] <hanson>  I guess link_to()'s default is GET, and link_to_remote()'s is POST?
 [17:34:55] <hanson>  works now ...
 [17:35:07] <ddadacha>  TBH I don't know
 [17:35:23] <ddadacha>  I have been going by the routes, if the routes says POST then I specify :method => post
 [17:35:23] <hanson>  yea I'm talking about the ones you did by mistake :D
 [17:35:33] <hanson>  let me try that
 [17:35:45] <ddadacha>  because I assume that whoever designed this initially did their own work on GET vs POST
 [17:35:56] <ddadacha>  that's also another reason for why I commented on your review btw
 [17:36:31] <ddadacha>  but then again, they might not have realized they were using one instead of the other :P
 [17:36:34] <ddadacha>  or not cared
 [17:36:35] <hanson>  yea ... thats true
 [17:36:36] <hanson>  hmm...
 [17:36:40] <hanson>  this is weird
 [17:36:47] <hanson>  :method => :post doing this doesn't work
 [17:36:50]  tobioboye_ (~drone@64.231.179.105) joined #markus.
 [17:36:53] <NelleV>  get should be used to retreive information, ie get data
 [17:37:06] <NelleV>  post should be used when modifying or creating data
 [17:37:12] <hanson>  post is for modification yea...
 [17:37:13]  tobioboye (~drone@69.156.29.233) left irc: Ping timeout: 260 seconds
 [17:37:13]  Nick change: tobioboye_ -> tobioboye
 [17:37:52] <ddadacha>  it's 'post'
 [17:37:56] <NelleV>  the inital works on routes has be done mostly by me, and the main idea was to make the tests pass, so there hasn't been a lot of "thinking" behind that :p
 [17:38:16] <hanson>  I have a feeling that link_to()'s don't work with :method => somethingnotGET
 [17:38:31] <hanson>  ddadacha: do you think you could try quickly with :method => :post ?
 [17:38:46] <ddadacha>  hanson: it's 'post' firstly..or does :post work?
 [17:38:50] <NelleV>  hanson: it does work with that
 [17:39:09] <hanson>  maybe something is really funky with my environment ...
 [17:39:14] <NelleV>  ddadacha: it is :post
 [17:39:20] <ddadacha>  ah I didn't know
 [17:39:43] <hanson>  both work, actually
 [17:39:52] <NelleV>  link_to("Destroy", "http://www.example.com", :method => :delete, :confirm => "Are you sure?") is an example
 [17:39:52] <hanson>  but rails API goes with the ":___" style ....
 [17:40:02] <ddadacha>  NelleV: btw, do you have access to markus-dev? I'd like to change the email it's sent to
 [17:40:07] <hanson>  NelleV: I am aware it is supposed to work, but it doesn't for me .....
 [17:40:13]  baadshah (~jay@user253-216.wireless.utoronto.ca) joined #markus.
 [17:40:30] <hanson>  any chance I'm missing some kinda JS driver or something?
 [17:40:34] <NelleV>  hanson: I'd tend to think there's a problem elsewhere :p
 [17:41:00] <NelleV>  ddadacha: markus-dev is a uoft based mailing list. i'm afraid you'll have to ask someone else
 [17:41:32] <ddadacha>  hanson: paste the link_to
 [17:41:40] <ddadacha>  the one I sent you was working for me
 [17:41:57] <hanson>  this is what I have now
 [17:41:58] <hanson>  link_to (I18n.t("remove"), remove_extra_mark_assignment_submission_result_path(:id => extra_mark.id), :method => :post, :confirm => I18n.t("marker.marks.confirm_remove_mark"), :remote => true)
 [17:41:58] <ddadacha>  and I copy pasted it in that email
 [17:42:08] <hanson>  yea I know :S
 [17:42:23] <ddadacha>  NelleV: thanks, I'll ask Karen then. Forgot it was {cdf,cs}.toronto.edu managed
 [17:42:50] <NelleV>  hanson: there's a problem in the route I think
 [17:42:54] <ddadacha>  k sanity check, move :method after :confirm
 [17:43:13] <ddadacha>  stupid but it actually matters for html stuff I believe
 [17:43:23] <hanson>  ddadacha: I've tried both :S
 [17:43:29] <NelleV>  hanson: you need two more parameters
 [17:43:30] <ddadacha>  and the route is POST?
 [17:43:36] <hanson>  after the :confirm is what I had first
 [17:43:42] <hanson>  post 'remove_extra_mark'
 [17:43:46] <hanson>  in routes.rb
 [17:43:58] <NelleV>  hanson: you need two more parameters
 [17:44:05] <hanson>  NelleV: which?
 [17:44:05] <NelleV>  hanson: one for the assignment id and one for the submission id
 [17:44:28] <NelleV>  hanson: this is a twice nested route, so you need for members three ids
 [17:44:47] <hanson>  the original link_to_remote didn't have any other params :S
 [17:45:01] <NelleV>  it didn't use the path helper, did it ?
 [17:45:11] <hanson>  nope
 [17:45:32] <NelleV>  it's probably the path helper failing
 [17:45:57] <NelleV>  hanson: I'm 99% sure it is that :p
 [17:46:00] <NelleV>  hanson: I may be wrong
 [17:46:17] <NelleV>  hanson: but try adding the :assignment_id and the :submission_id
 [17:46:22] <ddadacha>  but it wfm :/
 [17:46:23] <hanson>  NelleV: this is server ouput Started POST "/en/assignments/1/submissions/1/results/2/remove_extra_mark"
 [17:46:30] <hanson>  looks right to me?
 [17:46:33] <hanson>  i have no idea
 [17:46:34] <hanson>  :S
 [17:46:51] <hanson>  Processing by ResultsController#remove_extra_mark as JS Parameters: {"assignment_id"=>"1", "locale"=>"en", "submission_id"=>"1", "id"=>"2"} Redirected to http://0.0.0.0:3000/en
 [17:46:56] <hanson>  it does have those id's already
 [17:47:10] <hanson>  the weird thing is, it logs me out of the system after doing this
 [17:47:25] <NelleV>  hanson: what's the error message ?
 [17:47:43] <hanson>  there's no "error"
 [17:47:47] <hanson>  it just does a redirect
 [17:47:48] <NelleV>  oh
 [17:47:59] <NelleV>  then the :method is taken in account properly
 [17:48:03] <NelleV>  so that's not the problem
 [17:48:40] <ddadacha>  hanson: is it showing confirm for you at least? It's no longer deleting the mark for me :/
 [17:48:48] <hanson>  ddadacha: yup
 [17:48:52] <hanson>  confirm shows
 [17:49:07] <ddadacha>  ah didn't Egor change some routes around this
 [17:49:52] <hanson>  my hunch is there's something not working with our prototype stuff, since forcing link_to()'s to do something other than GET, requires some hacking using JS or something
 [17:51:02] <hanson>  cuz everytime theres a link_to() that uses some method other than GET, i haven't been able to get it to work :(
 [17:51:20] <ddadacha>  hmm
 [17:51:29] <ddadacha>  well figure out why Egor changed it to post instead of get
 [17:51:42] <ddadacha>  err actually no this should be post
 [17:51:47]  *** ddadacha is not thinking straight
 [17:52:19] <hanson>  https://github.com/rails/prototype-ujs
 [17:52:46] <hanson>  if I use chrome to inspect, i see data-remote and data-method tags generated...
 [17:55:27] <ddadacha>  :/ it's logging me out now every time I click if I use post
 [17:55:53] <hanson>  well I think the fact that if I remote :method => post (defaulting to get), and changing routes.rb to get and it works, means something is up with our prototype stuff
 [17:55:59] <hanson>  ddadacha: yup exactly what happens to me
 [17:56:14] <hanson>  remove***
 [17:56:34] <ddadacha>  agreed
 [17:57:06] <ddadacha>  hanson: do you think the link is heavy enough to be a button>?
 [17:57:27] <hanson>  ddadacha: yes
 [17:57:35] <hanson>  ddadacha: because it does a modification
 [17:57:38] <ddadacha>  yeah
 [17:57:58] <ddadacha>  either use button or link_to_function then
 [17:57:59] <hanson>  ddadacha: actually I think anything that uses post or delete should be a button