[00:01:38]  NelleV (~Nelle@unaffiliated/nellev) left irc: Ping timeout: 252 seconds
 [00:03:06]  NelleV (~Nelle@unaffiliated/nellev) joined #markus.
 [00:03:12]  #markus: mode change '+o NelleV' by MarkUsBot!~MarkUsBot@li136-145.members.linode.com
 [04:15:52]  Ayaya-Aaron-MBP (~Ayaya-Aar@S010600059a3c7a00.vf.shawcable.net) left irc: Quit: Ayaya-Aaron-MBP
 [06:32:05]  #markus: mode change '-o NelleV' by NelleV!~Nelle@unaffiliated/nellev
 [07:01:19]  Ayaya-Aaron-MBP (~Ayaya-Aar@S010600059a3c7a00.vf.shawcable.net) joined #markus.
 [07:20:07]  Ayaya-Aaron-MBP (~Ayaya-Aar@S010600059a3c7a00.vf.shawcable.net) left irc: Quit: Ayaya-Aaron-MBP
 [10:48:17]  karenreid (~karenreid@74.198.87.2) joined #markus.
 [10:53:43]  karenreid (~karenreid@74.198.87.2) left irc: Remote host closed the connection
 [10:53:53]  karenreid (~karenreid@vpn-shaper02.cs.toronto.edu) joined #markus.
 [10:54:05]  #markus: mode change '+o karenreid' by MarkUsBot!~MarkUsBot@li136-145.members.linode.com
 [10:56:41]  karenreid (~karenreid@vpn-shaper02.cs.toronto.edu) left irc: Client Quit
 [13:56:11]  Nick change: m_conley_away -> m_conley
 [14:22:57]  aimenk (~aimenk@199.243.188.82) joined #markus.
 [14:31:36] <aimenk>  hey xddadacha
 [14:31:37] <aimenk>  u there?
 [14:32:28] <aimenk>  hey m_conley u there? i had a question about sorting
 [14:33:13] <m_conley>  aimenk: hey - sure, shoot
 [14:33:31] <aimenk>  i was working on submission table
 [14:33:40] <aimenk>  adding first name and last name to the table
 [14:33:57] <aimenk>  this is for issue327
 [14:34:07] <aimenk>  and i m not sure how to get the sorting done for the names
 [14:34:44] <m_conley>  aimenk: right
 [14:34:56] <aimenk>  give me a sec
 [14:34:58] <aimenk>  i
 [14:35:00] <m_conley>  aimenk: so, once again, give me a sec to refresh my memory about FilterTable
 [14:35:07] <aimenk>  okk sure
 [14:35:18] <aimenk>  i'll tell u which file i was looking at for sorting
 [14:36:06] <aimenk>  i was looking at submissions_controller
 [14:36:23] <aimenk>  around like 62
 [14:36:48] <aimenk>  so to sort group_name it said: "'group_name' => lambda { |a,b| a.group.group_name.downcase <=> b.group.group_name.downcase},"
 [14:37:33] <aimenk>  so i tried to do this for first_name => " 'first_name' => lambda { |a,b| a.student.first_name.downcase <=> b.student.first_name.downcase}," but it didnt work :(
 [14:38:37] <m_conley>  aimenk: ok, still digging...
 [14:38:44] <aimenk>  okk sure m_conley
 [14:40:31] <aimenk>  m_conley: also i had one more question. i somehow merged my master branch to the branch i was working on and now my master has all the changes that i was working on, on it.
 [14:40:46] <aimenk>  is there a way i can get the changes removed from my master "master branch"
 [14:40:59] <m_conley>  aimenk: hm - let's deal with one problem at a time
 [14:41:07] <m_conley>  aimenk: we'll start with the table sorting problem
 [14:41:07] <aimenk>  kk sure m_conley
 [14:41:11] <aimenk>  kk cool
 [14:41:43] <m_conley>  aimenk: give me....5 minutes to review FilterTable
 [14:41:46] <m_conley>  and sorting, in particular
 [14:41:55] <aimenk>  yea sure m_conley
 [14:42:54] <m_conley>  aimenk: so can you give me a screenshot of how the submission table looks with your patch so far?
 [14:43:01] <m_conley>  aimenk: post it on imgur.com or something
 [14:43:04] <aimenk>  yea suree
 [14:44:44] <aimenk>  http://imgur.com/EDv3h
 [14:46:28] <m_conley>  aimenk: thanks, examining...
 [14:46:38] <aimenk>  m_conley: suree
 [14:46:58] <m_conley>  aimenk: what is the URL for the First Name / Last Name links in the table header?
 [14:47:36] <aimenk>  wat do u mean
 [14:47:53] <aimenk>  http://localhost:3000/en/assignments/2/submissions/browse?filter=none&id=2&page=1&per_page=30&sort_by=first_name
 [14:47:57] <aimenk>  this is for first_name
 [14:48:02] <m_conley>  ok, thanks
 [14:48:13] <aimenk>  i changed the first_name to this in the submission_controller so it cld stop giving me errors
 [14:48:18] <aimenk>  'first_name' => lambda { |a,b| a.group.group_name.downcase <=> b.group.group_name.downcase},
 [14:48:25] <aimenk>  for the time being.
 [14:50:47] <m_conley>  aimenk: what errors was it giving you before?
 [14:51:02] <aimenk>  i can send u a screen shot of error, give me a sec
 [14:51:51] <aimenk>  so when i click on first_name
 [14:51:54] <aimenk>  it gives me
 [14:51:54] <aimenk>  http://imgur.com/osD8N
 [14:52:14] <aimenk>  that's when i changed the code to 'first_name' => lambda { |a,b| a.student.first_name.downcase <=> b.student.first_name.downcase},
 [14:52:20] <m_conley>  aimenk: ah
 [14:52:37] <m_conley>  aimenk: so, in this case, a and b are Groupings
 [14:52:45] <aimenk>  ooohh
 [14:52:58] <aimenk>  hmm
 [14:53:13] <m_conley>  aimenk: hang on
 [14:53:17] <m_conley>  aimenk: let me get this straight
 [14:53:20] <aimenk>  kk
 [14:53:34] <m_conley>  aimenk: in this table, we're going to have a First Names column, to show *all* of the First Names of every Grouping member?
 [14:53:38] <m_conley>  and the same with Last Name?
 [14:53:46] <aimenk>  yesss
 [14:53:51] <aimenk>  thats what they wanted
 [14:54:03] <aimenk>  i mean i could have a column with just "Full Name"
 [14:54:15] <aimenk>  and have "Full Name" of all students in the group
 [14:54:38] <m_conley>  aimenk: ok, just making sure this is to spec
 [14:54:53] <aimenk>  oh ok
 [14:55:10] <aimenk>  sureee
 [14:55:20] <m_conley>  aimenk: so what is the expected behaviour when sorting this column? Do you just sort alphabetically by the first members first or last name?
 [14:55:35] <aimenk>  yeaa
 [14:55:43] <aimenk>  so sort with the first name on the list
 [14:55:46] <m_conley>  aimenk: or do you alphabetically sort the members, and THEN sort the groupings based on the name of the first member?
 [14:55:59] <aimenk>  name of the first memeber
 [14:56:44] <m_conley>  aimenk: alright
 [14:56:51] <aimenk>  yupp
 [14:57:05] <m_conley>  aimenk: so, first, we have an edge case - what about Groupings with no members?
 [14:57:18] <aimenk>  it'll be blank i guess then
 [14:57:23] <m_conley>  aimenk: we should probably have that result in the empty string
 [14:57:26] <m_conley>  right
 [14:57:38] <aimenk>  hmm
 [14:57:38] <m_conley>  aimenk: so, if I recall correctly, we can get the student memberships via:
 [14:59:38] <m_conley>  grouping.accepted_student_memberships.first.user.first_name
 [14:59:50] <aimenk>  hmm
 [14:59:55] <m_conley>  that should get you the first name of the first user for the accepted students for this grouping.
 [15:00:04] <aimenk>  oh okk
 [15:00:09] <m_conley>  aimenk: do you understand why?
 [15:00:27] <aimenk>  yea so u r asking first_name of the accepted students
 [15:00:44] <aimenk>  is this the accepted students in the group?
 [15:01:11] <m_conley>  aimenk: for this particular grouping
 [15:01:20] <aimenk>  oh okk
 [15:02:03] <aimenk>  this is what i wrote to get the first and last name
 [15:02:04] <aimenk>  http://pastie.org/3362792
 [15:02:46] <aimenk>  i wrote this code in views/submission/submission_table_row/_table_row.html.erb
 [15:03:21] <aimenk>  so it should be accepted_Students_membership.first.user.first_name instead?
 [15:03:25] <m_conley>  aimenk: hm - I think grouping.students returns *all* students, including rejected students.
 [15:03:33] <aimenk>  ohh okk
 [15:03:34] <aimenk>  hmm
 [15:03:35] <m_conley>  aimenk: I could be wrong
 [15:03:38] <m_conley>  aimenk: it's been a little while
 [15:04:36] <aimenk>  oh okk
 [15:05:49] <aimenk>  grouping.accepted_student_memberships.first.user.first_name : does this give the name of only the first member in the group?
 [15:10:08] <m_conley>  aimenk: yep
 [15:10:17] <aimenk>  hm
 [15:10:21] <aimenk>  how would i get name of all
 [15:10:37] <aimenk>  grouping.accepted_student_memberships.all.user.first_name ?
 [15:15:02] <m_conley>  aimenk: what do you want them as? A comma separated string? An array?
 [15:15:14] <aimenk>  a comma seperate would be better
 [15:15:25] <aimenk>  as the user names are seperated by comma as well
 [15:15:53] <aimenk>  so usernames look like ( usera, userb, userc) i would like first name to be "Fname1, Fname2, Fname3"
 [15:17:26] <m_conley>  k, lemme see...
 [15:17:33] <aimenk>  kk thnxx
 [15:17:52] <NelleV>  list comprehension ? :p
 [15:20:58] <m_conley>  NelleV: are list comprehensions available in Ruby?
 [15:21:32] <NelleV>  m_conley: nope :(
 [15:21:48] <m_conley>  first_names = grouping.accepted_student_memberships.collect {|m| m.user.first_name}
 [15:21:57] <m_conley>  cs_string = first_names.join(',')
 [15:22:08] <m_conley>  (my Ruby is a little rusty)
 [15:24:57] <aimenk>  so that would be a new def in grouping
 [15:25:41] <aimenk>  ?
 [15:26:02] <m_conley>  aimenk: ok, maybe I'm a bit confused here - *where* are you generating these strings?
 [15:26:41] <aimenk>  the pastie i showed u was in views/submissions/submissions_table_row
 [15:26:57] <aimenk>  in _table_row.html.erb
 [15:27:44] <m_conley>  Oh. In that case, I'd do:
 [15:28:01] <aimenk>  so the two files i m working on 1. submission_controller 2. views/submissions/submissions_table_row/_table_row.html
 [15:28:13] <aimenk>  and the first one deals with sorting, second one displaying string
 [15:28:25] <m_conley>  <% grouping.accepted_student_memberships do |membership| %>
 [15:28:40] <m_conley>  <%= membership.user.first_name %>
 [15:28:44] <m_conley>  <% end %>
 [15:29:02] <aimenk>  kk let me try
 [15:29:20] <NelleV>  mmh
 [15:29:22] <aimenk>  oh that didnt work
 [15:29:26] <NelleV>  there's a for loop missing here
 [15:29:27] <aimenk>  didnt display anyting :s
 [15:29:38]  *** m_conley 's brain explodes
 [15:29:44] <m_conley>  Alright - I have to eat something
 [15:29:48] <m_conley>  I'll be back in about 20 min
 [15:29:54] <NelleV>  <% grouping.accepted_student_memberships do |membership| %>
 [15:29:56] <NelleV>  oups
 [15:29:57] <aimenk>  m_conley: oh ok
 [15:30:03] <NelleV>  <% grouping.accepted_student_memberships.each do |membership| %>
 [15:30:07] <NelleV>  and then the rest
 [15:30:12] <aimenk>  thanks NelleV
 [15:30:14] <aimenk>  let me try
 [15:30:43] <aimenk>  oh NelleV thankss that worked!! :D
 [15:32:46] <aimenk>  NelleV: also my issue in the beginning was with sorting
 [15:33:06] <aimenk>  i m not exactly sure how to get the sorting for firth_name, thats in the submission_Controller file
 [15:33:43] <NelleV>  I don't understand what you mean by sorting
 [15:34:07] <aimenk>  like sorting first_names
 [15:34:16] <aimenk>  actually i tried this accepted_student_memberships.first.user.first_name and it seem to work
 [15:34:36] <aimenk>  so basically i want to sort the list of first_names by the name of first member in the group
 [15:34:39] <NelleV>  sorting first_names per alphabetical order ?
 [15:34:45] <aimenk>  yesss
 [15:34:59] <aimenk>  like if there are 4 to 5 groups in the list
 [15:35:06] <NelleV>  for which ticket is that ?
 [15:35:11] <aimenk>  327
 [15:36:02] <NelleV>  ok, so I don't know how you understood that
 [15:36:10] <NelleV>  one sec
 [15:36:16] <aimenk>  kk
 [15:37:51] <NelleV>  so that's the view he is talking about: http://localhost:3000/en/assignments/1/graders
 [15:38:12] <NelleV>  man, this is never gonna fit /o\
 [15:38:58] <aimenk>  yea i did it on the graders side
 [15:39:04] <aimenk>  i thought they wanted it on submissions as well
 [15:39:23] <NelleV>  I don't think this is a good idea, UI wise
 [15:39:42] <aimenk>  hmm
 [15:39:58] <NelleV>  aimenk: do you mind putting a hold on that ? i'll send an email to Benjamin to see what he was thinking of. This needs more thinking
 [15:40:09] <aimenk>  oh okk
 [15:40:19] <aimenk>  so should i not work on this right now?
 [15:40:30] <NelleV>  well, I can explain to you what I am afraid of
 [15:40:54] <aimenk>  suree
 [15:40:55] <NelleV>  it's quite simple. The views are alread quite filled with information, and I don't think we will have the space to put everything
 [15:41:02] <aimenk>  hmm
 [15:41:08] <aimenk>  so u think it'll be too much info
 [15:41:10] <aimenk>  on one table
 [15:41:15] <NelleV>  so unless we manage to squash things more, it's not going to fit
 [15:41:21] <NelleV>  at least on my screen
 [15:41:24] <aimenk>  oh ok
 [15:41:45] <aimenk>  would it work if we just add "Full Name"
 [15:42:01] <aimenk>  as that wont be taking up too much space
 [15:42:20] <NelleV>  What do you mean by "Full Name" ?
 [15:42:32] <aimenk>  instead of having "first Name" and "last name" columns
 [15:42:37] <aimenk>  just have one "Full Name"
 [15:42:41] <NelleV>  oh, yes indeed
 [15:42:48] <NelleV>  I don't even think we need a column
 [15:42:51] <aimenk>  so "Fname1 LName1" together
 [15:42:53] <aimenk>  noo
 [15:43:10] <aimenk>  hmm
 [15:43:11] <NelleV>  we could have c5granad (firstname last name)
 [15:43:28] <aimenk>  next to the name?
 [15:43:31] <NelleV>  but even in tiny, it's going to take at least twice the space